Date: Tue, 28 Sep 2004 13:18:28 +0200 (CEST)
From: Jesper Juhl <juhl-lkml@dif.dk>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
       Nico Schottelius <nico-kernel@schottelius.org>
Subject: Re: [PATCH] add sysfs attribute 'carrier' for net devices
In-Reply-To: <1096306153.1729.2.camel@localhost.localdomain>
Message-ID: <Pine.LNX.4.61.0409281316191.22088@jjulnx.backbone.dif.dk>
References: <Pine.LNX.4.61.0409270041460.2886@dragon.hygekrogen.localhost>
 <1096306153.1729.2.camel@localhost.localdomain>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1262
Lines: 40

On Mon, 27 Sep 2004, Stephen Hemminger wrote:

> Date: Mon, 27 Sep 2004 10:29:13 -0700
> From: Stephen Hemminger <shemminger@osdl.org>
> To: Jesper Juhl <juhl-lkml@dif.dk>
> Cc: linux-kernel <linux-kernel@vger.kernel.org>,
>     Nico Schottelius <nico-kernel@schottelius.org>
> Subject: Re: [PATCH] add sysfs attribute 'carrier' for net devices
> 
> On Mon, 2004-09-27 at 00:51 +0200, Jesper Juhl wrote:
> >  
> > +static ssize_t show_carrier(struct class_device *dev, char *buf)
> > +{
> > +	struct net_device *net = to_net_dev(dev);
> > +	if (netif_running(net)) {
> > +		if (netif_carrier_ok(net))
> > +			return snprintf(buf, 3, "%d\n", 1);
> > +		else
> > +			return snprintf(buf, 3, "%d\n", 0);
> 
> Using snprintf in this way is kind of silly. since buffer is PAGESIZE.
> The most concise format of this would be:
> 	return sprintf(buf, dec_fmt, !!netif_carrier_ok(dev));
> 

I see your point and I'll create a new patch this evening when I get home 
from work.
Thank you for your feedback.


--
Jesper Juhl


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/