Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267840AbUI1OJ1 (ORCPT ); Tue, 28 Sep 2004 10:09:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267829AbUI1OHT (ORCPT ); Tue, 28 Sep 2004 10:07:19 -0400 Received: from bhhdoa.org.au ([216.17.101.199]:17668 "EHLO bhhdoa.org.au") by vger.kernel.org with ESMTP id S267808AbUI1OGJ (ORCPT ); Tue, 28 Sep 2004 10:06:09 -0400 Date: Tue, 28 Sep 2004 17:05:02 +0300 (EAT) From: Zwane Mwaikambo To: Kenji Kaneshige Cc: Linux Kernel , long , Andrew Morton , Greg Kroah-Hartmann , Len Brown , tony.luck@intel.com, acpi-devel@lists.sourceforge.net, linux-ia64@vger.kernel.org Subject: Re: [ACPI] [PATCH] Updated patches for PCI IRQ resource deallocation support [2/3] In-Reply-To: <4157A9D7.4090605@jp.fujitsu.com> Message-ID: References: <4157A9D7.4090605@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1028 Lines: 27 On Mon, 27 Sep 2004, Kenji Kaneshige wrote: > > > Why not just make these static inlines in header files? Since you're on > > > this, how about making irq_desc and friends dynamic too? > > I'm not quite sure what you are saying, but my idea is defining > acpi_unregister_gsi() as a opposite part of acpi_register_gsi(). > Acpi_register_gsi() is defined for each arch (i386, ia64), so > acpi_unregister_gsi() is defined for each i386 and ia64 too. Well i meant can't you define them in a header file as follows; static void inline acpi_unregister_gsi (unsigned int irq) { } An advantage is that it saves memory since you don't also have to create the extra data objects for the exported symbol. But really you don't have to export something which does nothing. Thanks, Zwane - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/