Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269166AbUI2XZJ (ORCPT ); Wed, 29 Sep 2004 19:25:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269186AbUI2XZJ (ORCPT ); Wed, 29 Sep 2004 19:25:09 -0400 Received: from e35.co.us.ibm.com ([32.97.110.133]:62901 "EHLO e35.co.us.ibm.com") by vger.kernel.org with ESMTP id S269166AbUI2XYz (ORCPT ); Wed, 29 Sep 2004 19:24:55 -0400 Date: Wed, 29 Sep 2004 16:25:58 -0700 From: Hanna Linder To: Alan Cox cc: Hanna Linder , Linux Kernel Mailing List , kernel-janitors@lists.osdl.org, greg@kroah.com, kraxel@bytesex.org Subject: Re: [PATCH 2.6.9-rc2-mm4 zr36120.c][5/8] Convert pci_find_device to pci_dev_present Message-ID: <24740000.1096500358@w-hlinder.beaverton.ibm.com> In-Reply-To: <1096496127.16721.10.camel@localhost.localdomain> References: <19730000.1096496900@w-hlinder.beaverton.ibm.com> <1096496127.16721.10.camel@localhost.localdomain> X-Mailer: Mulberry/2.2.1 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 853 Lines: 25 --On Wednesday, September 29, 2004 11:15:30 PM +0100 Alan Cox wrote: > On Mer, 2004-09-29 at 23:28, Hanna Linder wrote: >> The dev was not used from pci_find_device so it was acceptable to replace >> with pci_dev_present. There was no need for it to be in a while loop originally. >> Compile tested. > > That code should die I think. All the tests it does are done in > pci/quirks.c and set up pci_pci_flags > > The whole driver is CONFIG_BROKEN anyway... I only verified my changes didn't add new compiler errors. What part should I remove? Just this check? Thanks. Hanna - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/