Date: Wed, 29 Sep 2004 17:21:01 -0700
From: Greg KH <greg@kroah.com>
To: Roland Dreier <roland@topspin.com>
Cc: pj@sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][2/2] [take 2] USB: use add_hotplug_env_var in core/usb.c
Message-ID: <20040930002100.GA27439@kroah.com>
References: <200409281919.aKAVlO4yKkPzE7f0@topspin.com> <200409281919.8RXPZodVBIYTqtXg@topspin.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200409281919.8RXPZodVBIYTqtXg@topspin.com>
User-Agent: Mutt/1.5.6i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1007
Lines: 27

On Tue, Sep 28, 2004 at 07:19:34PM -0700, Roland Dreier wrote:
> Use the new add_hotplug_env_var() function in drivers/usb/core/usb.c.
> In addition to cleaning up the code, this fixes a (probably harmless)
> bug here: for each value added to the environment, the code did
> 
> 	length += sprintf(...);
> 
> and then
> 
> 	scratch += length;
> 
> which means that we skip the sum of the lengths of all the values
> we've put so far, rather than just the length of the value we just
> put.  This is probably harmless since we're unlikely to run out of
> space but if nothing else it's setting a bad example....
> 
> I've tested this on a system with USB floppy and CD-ROM; hotplug gets
> the same environment with the patch as without.

Applied, thanks.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/