Date: Thu, 30 Sep 2004 18:07:10 +0200
Message-ID: <s5hekkjpwpd.wl@alsa2.suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: Borislav Petkov <petkov@uni-muenster.de>, linux-kernel@vger.kernel.org,
       bbpetkov@yahoo.de
Subject: Re: [PATCH] 2.6.9-rc3 fix warnings in sound/drivers/opl3/opl3_lib.c
In-Reply-To: <20040930155228.GE23987@parcelfarce.linux.theplanet.co.uk>
References: <20040930122853.GA28332@none>
	<20040930152544.GD23987@parcelfarce.linux.theplanet.co.uk>
	<20040930155228.GE23987@parcelfarce.linux.theplanet.co.uk>
User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 15) (Security Through Obscurity) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2120
Lines: 49

At Thu, 30 Sep 2004 16:52:28 +0100,
viro@parcelfarce.linux.theplanet.co.uk wrote:
> 
> On Thu, Sep 30, 2004 at 04:25:44PM +0100, viro@parcelfarce.linux.theplanet.co.uk wrote:
> > On Thu, Sep 30, 2004 at 02:28:53PM +0200, Borislav Petkov wrote:
> > > Hi there,
> > >    I get these warnings while compiling 2.6.9-rc3:
> > >    sound/drivers/opl3/opl3_lib.c: In function `snd_opl3_cs4281_command':   
> > >    sound/drivers/opl3/opl3_lib.c:101: warning: passing arg 2 of `writel'  makes pointer from integer without a cast   
> > >    sound/drivers/opl3/opl3_lib.c:104: warning: passing arg 2 of `writel'  makes pointer from integer without a cast
> > >    
> > >    Hope this fix is correct.
> > 
> > It looks very odd.  At the very least we don't want to overload the
> > fields in question (->r_port and ->l_port) that way.
> 
> *Yuck*
> 
> ALSA code, as pretty as ever.  No, that's not a fix; it's only shutting the
> rightfully complaining compiler up.
> 
> What happens there is a dirty kludge created for the benefit of a single
> driver (sound/pci/cs4281.c).  Said driver has a bunch of registers
> memory-mapped, while its relatives use port IO instead.  Driver does
> (correctly) ioremap(); then it overloads the arguments of snd_opl3_create()
> normally used for port numbers and shoves *address obtained from ioremap
> and divided by 4* in them.

This ugly shift was already removed in the current version
in linux-sound bk.  The l_port and r_port point the iomem pointers now
on cs4281 like others.  I don't know why the author of cs4281
implemented in such a way.

BTW, all __iomem fixes are already there, too.

> Sigh...  At the very least that kind of abuse should stop.  FWIW, I would
> suggest having cs4281.c set the ->command() directly and killing that crap
> with ->l_port/->r_port overloading.

Yes, it'd be definitely better.
Will work on it.


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/