Date: Thu, 30 Sep 2004 21:33:45 +0200
From: maximilian attems <janitor@sternwelten.at>
To: linux-kernel@vger.kernel.org
Cc: marcelo.tosatti@cyclades.com, sam@ravnborg.org, arnold@skeeve.com
Subject: Re: [patch 2.4] menuconfig fix crash due to infinite recursion
Message-ID: <20040930193345.GA1848@stro.at>
References: <20040929161905.GK1835@stro.at>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040929161905.GK1835@stro.at>
User-Agent: Mutt/1.5.6+20040722i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1303
Lines: 47


 gawk(1) tells that getline "returns 0 on end of file and -1 on an error."
 in current script for menuconfig if getline has an error,
 it is still treated as true, fix _both_ of its invocations.
 
 2.6 don't use that script anymore.
 fix suggestion from Aharon Robbins <arnold@skeeve.com>
 debian bts has 2 bugs open concerning that issue,
 this is the one containing belows fix:
 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=147469
 
 [TM] tested.
 menuconfig still works for me. ;)
 

--- a/scripts/Menuconfig	2002-08-03 02:39:46.000000000 +0200
+++ b/scripts/Menuconfig	2004-09-30 21:29:21.000000000 +0200
@@ -714,7 +714,7 @@ BEGIN {
 
 function parser(ifile,menu) {
 
-	while (getline <ifile) {
+	while ((getline <ifile) > 0) {
 		if ($1 == "mainmenu_option") {
 			comment_is_option = "1"
 		}
@@ -761,7 +761,7 @@ BEGIN {
 
 function parser(ifile,menu) {
 
-	while (getline <ifile) {
+	while ((getline <ifile) > 0) {
 		if ($0 ~ /^#|$MAKE|mainmenu_name/) {
 			printf("") >>menu
 		}
 
 
--
maks
kernel janitor  	http://janitor.kernelnewbies.org/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/