Date: Thu, 30 Sep 2004 12:53:17 -0700
From: "David S. Miller" <davem@davemloft.net>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: torvalds@osdl.org, franz_pletz@t-online.de, michal@rokos.info,
       linux-kernel@vger.kernel.org, akpm@osdl.org, manfred@colorfullife.com
Subject: Re: [PATCH 2.6] Natsemi - remove compilation warnings
Message-Id: <20040930125317.5622a909.davem@davemloft.net>
In-Reply-To: <415C4EC5.4040603@pobox.com>
References: <200409230958.31758.michal@rokos.info>
	<200409231618.56861.michal@rokos.info>
	<415C37D8.20203@t-online.de>
	<Pine.LNX.4.58.0409300951150.2403@ppc970.osdl.org>
	<415C4EC5.4040603@pobox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 719
Lines: 17

On Thu, 30 Sep 2004 14:21:57 -0400
Jeff Garzik <jgarzik@pobox.com> wrote:

> Wouldn't it be better to just phase out the base of dev->base_addr 
> completely?  I tend to prefer adding a "void __iomem *regs" to struct 
> netdev_private, and ignore dev->base_addr completely.

Yes, this is the way to go.

(BTW, Jeff, technically it's the 'ifmap' that the user uses
 to pass base_addr into the kernel.  The kernel drivers use
 the netdev struct one, which is an unsigned long)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/