Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269534AbUI3Vf3 (ORCPT ); Thu, 30 Sep 2004 17:35:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269523AbUI3Vf3 (ORCPT ); Thu, 30 Sep 2004 17:35:29 -0400 Received: from mx1.redhat.com ([66.187.233.31]:11746 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S269518AbUI3VfR (ORCPT ); Thu, 30 Sep 2004 17:35:17 -0400 Date: Thu, 30 Sep 2004 17:35:00 -0400 From: Alan Cox To: Bartlomiej Zolnierkiewicz Cc: Alan Cox , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: PATCH: (Test) it8212 driver for 2.6.9rc3 Message-ID: <20040930213500.GC2175@devserv.devel.redhat.com> References: <20040930184535.GA31197@devserv.devel.redhat.com> <200409302218.48115.bzolnier@elka.pw.edu.pl> <200409302245.18866.bzolnier@elka.pw.edu.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200409302245.18866.bzolnier@elka.pw.edu.pl> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 753 Lines: 24 On Thu, Sep 30, 2004 at 10:45:18PM +0200, Bartlomiej Zolnierkiewicz wrote: > - merge+describe needed IDE core changes Happily. I'm of the opinion the "ident whacking" callback isnt justified, only one driver has a need for it and that driver can do it in the iops hook. > - fix coding style and whitespace damage Yeah > - kill useless DECLARE_ITE_DEV macro I'd prefer to keep it (there are likely to be some related devices from the databook) > - add __init to it8212_ide_init() Good point - will fix - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/