From: Roland =?utf-8?q?Ca=C3=9Febohm?= 
	<roland.cassebohm@VisionSystems.de>
Organization: Vision Systems GmbH
To: linux-kernel@vger.kernel.org
Subject: Re: Serial driver hangs
Date: Fri, 1 Oct 2004 17:22:28 +0200
User-Agent: KMail/1.6.2
Cc: Paul Fulghum <paulkf@microgate.com>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
       Russell King <rmk+lkml@arm.linux.org.uk>
References: <200409281734.38781.roland.cassebohm@visionsystems.de> <1096575030.19487.50.camel@localhost.localdomain> <1096579503.1938.166.camel@deimos.microgate.com>
In-Reply-To: <1096579503.1938.166.camel@deimos.microgate.com>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <200410011722.28877.roland.cassebohm@visionsystems.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1830
Lines: 49

Am Donnerstag, 30. September 2004 23:25 schrieb Paul Fulghum:
> On Thu, 2004-09-30 at 15:10, Alan Cox wrote:
> > On Iau, 2004-09-30 at 21:30, Paul Fulghum wrote:
> > > tty->flip.work.func and tty->flip.tqueue.routine
> > > are set to flush_to_ldisc()
> >
> > flush_to_ldisc was ok, then someone added the low latency
> > flag. In the current 2.6.9rc3 patch flush_to_ldisc
> > honours TTY_DONT_FLIP also
>
> In the cases I described the low latency flag
> does not come into play because flush_to_ldisc()
> is called directly instead of
> through tty_flip_buffer_push().
>
> TTY_DONT_FLIP is only set in read_chan().
> If read_chan() is not running, TTY_DONT_FLIP is not
> set and does not prevent buffers from flipping
> if the ISR calls flush_to_ldisc() directly
> while ldisc->receive_buf() is running.
>
> The answer seems to be: don't call
> flush_to_ldisc directly like the current
> serial driver does.

Yes, I think you are right, if the system is to slow to fetch 
the data fast enough the buffer will be sometime full. And if 
it would be possible to use the second flip buffer then, this 
buffer would be full too sometime.
It would just take a little longer till data got lost. But if 
I want that I could just make the buffers larger.

...

I have just tested it, but unfortunately I've got a very bad 
result. :-( In my test case (2 port with 921600 baud) I get 
very much data loss.

I think I will stay now by the solution of just trow away the 
characters from the FIFO if flip buffer is full and 
TTY_DONT_FLIP is set. I will test now the patch Paul has 
made.

Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/