Date: Fri, 1 Oct 2004 12:22:38 -0700
From: Greg KH <greg@kroah.com>
To: "Teras Timo (EXT-YomiGroup/Helsinki)" <Ext-Timo.Teras@nokia.com>
Cc: Robert Love <rml@novell.com>, linux-kernel@vger.kernel.org
Subject: Re: kobject events questions
Message-ID: <20041001192238.GA24404@kroah.com>
References: <415ABA96.6010908@nokia.com> <1096486749.4666.31.camel@betsy.boston.ximian.com> <415D28B7.5070306@nokia.com> <20041001164750.GA11646@kroah.com> <20041001184714.GA19587@two.research.nokia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20041001184714.GA19587@two.research.nokia.com>
User-Agent: Mutt/1.5.6i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1395
Lines: 29

On Fri, Oct 01, 2004 at 09:47:14PM +0300, Teras Timo (EXT-YomiGroup/Helsinki) wrote:
> On Fri, Oct 01, 2004 at 09:47:50AM -0700, ext Greg KH wrote:
> > > I'm just a bit dubious about adding new signals since they are hardcoded 
> > > in the kernel. It's a time consuming process to add new signals (either 
> > > for development build or for official kernels). This is one of the 
> > > reasons I liked more about the original kevent patch. Wouldn't simple 
> > > #defines have been enough for signal names?
> > 
> > What's the difference between a #define and a enum?  We want these to be
> > well known, and correct.  A enum gives us that.
> 
> I was a bit ambiguous. I meant #defines with string literals. That would
> have assured correct signal names. I guess to have them all well known
> justifies for enums (even though it makes adding new ones a bit more
> difficult).

That's the point.  It should "be difficult" in that you need to present
a valid reason to the whole kernel community as to why a new event needs
to be added.  But if you make a point that others agree with, then there
should be no problem in adding it.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/