Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263743AbUJAUqW (ORCPT ); Fri, 1 Oct 2004 16:46:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266513AbUJAUmY (ORCPT ); Fri, 1 Oct 2004 16:42:24 -0400 Received: from mail0.lsil.com ([147.145.40.20]:38101 "EHLO mail0.lsil.com") by vger.kernel.org with ESMTP id S266574AbUJAUkc (ORCPT ); Fri, 1 Oct 2004 16:40:32 -0400 Message-ID: <0E3FA95632D6D047BA649F95DAB60E570230C986@exa-atlanta> From: "Bagalkote, Sreenivas" To: "'James Bottomley'" , "Bagalkote, Sreenivas" Cc: "Mukker, Atul" , "'linux-kernel@vger.kernel.org'" , "'linux-scsi@vger.kernel.org'" , "'bunk@fs.tum.de'" , "'Andrew Morton'" , "'Matt_Domsch@dell.com'" , "Ju, Seokmann" Subject: RE: [PATCH]: megaraid 2.20.4: Fixes a data corruption bug Date: Fri, 1 Oct 2004 16:32:46 -0400 MIME-Version: 1.0 X-Mailer: Internet Mail Service (5.5.2657.72) Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1477 Lines: 40 Without CONFIG_COMPAT around them, I get "unresolved symbol" for (un)register_ioctl32_conversion while loading the module. Thanks, Sreenivas >-----Original Message----- >From: James Bottomley [mailto:James.Bottomley@SteelEye.com] >Sent: Friday, October 01, 2004 4:24 PM >To: Bagalkote, Sreenivas >Cc: Mukker, Atul; 'linux-kernel@vger.kernel.org'; >'linux-scsi@vger.kernel.org'; 'bunk@fs.tum.de'; 'Andrew Morton'; >'Matt_Domsch@dell.com'; Ju, Seokmann >Subject: RE: [PATCH]: megaraid 2.20.4: Fixes a data corruption bug > > >On Fri, 2004-10-01 at 16:08, Bagalkote, Sreenivas wrote: >> The submitted previous version of megaraid (2.20.3.1) had >> register_ioctl32_conversion & unregister_ioctl32_conversion >> defined to empty statements if CONFIG_COMPAT was _not_ >> defined. > > >> But I think the preferred way was to have the occurances of >> (un)register_ioctl32_conversion in the code surrounded by >> #ifdef CONFIG_COMPAT ... #endif directly. In the kernel source >> only register_ioctl32_conversion has these #ifdef .. #endif. The >> unregister_ioctl32_conversion doesn't. > >Actually, because of the way linux/ioctl32 defines these, the #ifdef >CONFIG_COMPAT is unnecessary even around register_ioctl32_... > >James > > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/