Date: Mon, 4 Oct 2004 12:37:25 -0700
From: Andrew Morton <akpm@osdl.org>
To: Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com>
Cc: jeffpc@optonline.net, linux-kernel@vger.kernel.org, torvalds@osdl.org,
       trivial@rustcorp.com.au, rusty@rustcorp.com.au
Subject: Re: [PATCH 2.6][resend] Add DEVPATH env variable to hotplug helper
 call
Message-Id: <20041004123725.58f1e77c.akpm@osdl.org>
In-Reply-To: <20041004102220.A3304@unix-os.sc.intel.com>
References: <20041003100857.GB5804@optonline.net>
	<20041003162012.79296b37.akpm@osdl.org>
	<20041004102220.A3304@unix-os.sc.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1437
Lines: 31

Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com> wrote:
>
>  On Sun, Oct 03, 2004 at 04:20:12PM -0700, Andrew Morton wrote:
>  > Does CPU hotplug behave correctly wrt /sys/devices/system/cpu?  Given that
>  > register_cpu() is still marked __init, I assume not.
> 
>  Currently what we have in the kernel is logical cpu hotplug, i.e once the
>  cpu is registered via register_cpu() that cpu can only go offline and still
>  the entry for that cpu will be present in the /sys/devices/system/cpu/cpuX/online.
> 
>  So __init register_cpu() is fine untill we support unregister_cpu()
>  which is required for physical cpu hotplug case.
> 
>  I have submitted ACPI based physical cpu hotplug patches and waiting to here from
>  ACPI mainitainer Len Brown, there I have taken care to support unregister_cpu()
>  and register_cpu() is marked as __devinit in those patches.

OK...

But still, cpu_run_sbin_hotplug() should not exist.  It is duplicating
(indeed, emulating) kobject_hotplug() behaviour.  To the extent that it now
has a hardwired sysfs path embedded in it:

	sprintf(devpath_str, "DEVPATH=devices/system/cpu/cpu%d", cpu);

which should have been obtained from kobject_get_path().
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/