Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268303AbUJDTxV (ORCPT ); Mon, 4 Oct 2004 15:53:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268263AbUJDTxU (ORCPT ); Mon, 4 Oct 2004 15:53:20 -0400 Received: from fmr03.intel.com ([143.183.121.5]:23977 "EHLO hermes.sc.intel.com") by vger.kernel.org with ESMTP id S268303AbUJDToJ (ORCPT ); Mon, 4 Oct 2004 15:44:09 -0400 Date: Mon, 4 Oct 2004 12:43:55 -0700 From: Keshavamurthy Anil S To: Andrew Morton Cc: Keshavamurthy Anil S , jeffpc@optonline.net, linux-kernel@vger.kernel.org, torvalds@osdl.org, trivial@rustcorp.com.au, rusty@rustcorp.com.au Subject: Re: [PATCH 2.6][resend] Add DEVPATH env variable to hotplug helper call Message-ID: <20041004124355.A17894@unix-os.sc.intel.com> Reply-To: Keshavamurthy Anil S References: <20041003100857.GB5804@optonline.net> <20041003162012.79296b37.akpm@osdl.org> <20041004102220.A3304@unix-os.sc.intel.com> <20041004123725.58f1e77c.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20041004123725.58f1e77c.akpm@osdl.org>; from akpm@osdl.org on Mon, Oct 04, 2004 at 12:37:25PM -0700 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1738 Lines: 37 On Mon, Oct 04, 2004 at 12:37:25PM -0700, Andrew Morton wrote: > Keshavamurthy Anil S wrote: > > > > On Sun, Oct 03, 2004 at 04:20:12PM -0700, Andrew Morton wrote: > > > Does CPU hotplug behave correctly wrt /sys/devices/system/cpu? Given that > > > register_cpu() is still marked __init, I assume not. > > > > Currently what we have in the kernel is logical cpu hotplug, i.e once the > > cpu is registered via register_cpu() that cpu can only go offline and still > > the entry for that cpu will be present in the /sys/devices/system/cpu/cpuX/online. > > > > So __init register_cpu() is fine untill we support unregister_cpu() > > which is required for physical cpu hotplug case. > > > > I have submitted ACPI based physical cpu hotplug patches and waiting to here from > > ACPI mainitainer Len Brown, there I have taken care to support unregister_cpu() > > and register_cpu() is marked as __devinit in those patches. > > OK... > > But still, cpu_run_sbin_hotplug() should not exist. It is duplicating > (indeed, emulating) kobject_hotplug() behaviour. To the extent that it now > has a hardwired sysfs path embedded in it: > > sprintf(devpath_str, "DEVPATH=devices/system/cpu/cpu%d", cpu); > > which should have been obtained from kobject_get_path(). Yes, I agree to your point that cpu_run_sbin_hotplug() is duplication kobject_hotplug() behaviour. I will send you a patch to fix this ASAP(hopefully before end of today). thanks, Anil - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/