Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268739AbUJECel (ORCPT ); Mon, 4 Oct 2004 22:34:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268745AbUJECel (ORCPT ); Mon, 4 Oct 2004 22:34:41 -0400 Received: from mail22.syd.optusnet.com.au ([211.29.133.160]:59327 "EHLO mail22.syd.optusnet.com.au") by vger.kernel.org with ESMTP id S268739AbUJECej (ORCPT ); Mon, 4 Oct 2004 22:34:39 -0400 References: <200410050216.i952Gb620657@unix-os.sc.intel.com> Message-ID: X-Mailer: http://www.courier-mta.org/cone/ From: Con Kolivas To: =?ISO-8859-1?B?Q2hlbiw=?= Kenneth W Cc: linux-kernel@vger.kernel.org Subject: Re: bug in sched.c:activate_task() Date: Tue, 05 Oct 2004 12:34:30 +1000 Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset="US-ASCII" Content-Disposition: inline Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 729 Lines: 19 Chen, Kenneth W writes: > Update p->timestamp to "now" in activate_task() doesn't look right > to me at all. p->timestamp records last time it was running on a > cpu. activate_task shouldn't update that variable when it queues > a task on the runqueue. > > This bug (and combined with others) triggers improper load balancing. The updated timestamp was placed there by Ingo to detect on-runqueue time. If it is being used for load balancing then it is being used in error. Con - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/