Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268851AbUJEGzc (ORCPT ); Tue, 5 Oct 2004 02:55:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268854AbUJEGzc (ORCPT ); Tue, 5 Oct 2004 02:55:32 -0400 Received: from mx1.redhat.com ([66.187.233.31]:42201 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S268851AbUJEGzb (ORCPT ); Tue, 5 Oct 2004 02:55:31 -0400 Date: Tue, 5 Oct 2004 02:54:47 -0400 (EDT) From: Ingo Molnar X-X-Sender: mingo@devserv.devel.redhat.com To: Con Kolivas cc: =?ISO-8859-1?B?Q2hlbiw=?= Kenneth W , linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: bug in sched.c:activate_task() In-Reply-To: Message-ID: References: <200410050216.i952Gb620657@unix-os.sc.intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 687 Lines: 20 On Tue, 5 Oct 2004, Con Kolivas wrote: > unsigned long long delta = now - next->timestamp; > > if (next->activated == 1) > delta = delta * (ON_RUNQUEUE_WEIGHT * 128 / 100) / 128; > > is in schedule() before we update the timestamp, no? indeed ... so the patch is just random incorrect damage that happened to distrub the scheduler fixing some balancing problem. Kenneth, what precisely is the balancing problem you are seeing? Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/