Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268854AbUJEHA3 (ORCPT ); Tue, 5 Oct 2004 03:00:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268860AbUJEHA2 (ORCPT ); Tue, 5 Oct 2004 03:00:28 -0400 Received: from mail06.syd.optusnet.com.au ([211.29.132.187]:24261 "EHLO mail06.syd.optusnet.com.au") by vger.kernel.org with ESMTP id S268854AbUJEG7t (ORCPT ); Tue, 5 Oct 2004 02:59:49 -0400 References: <200410050216.i952Gb620657@unix-os.sc.intel.com> Message-ID: X-Mailer: http://www.courier-mta.org/cone/ From: Con Kolivas To: Ingo Molnar Cc: Con Kolivas , =?ISO-8859-1?B?Q2hlbiw=?= Kenneth W , linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: bug in sched.c:activate_task() Date: Tue, 05 Oct 2004 16:59:27 +1000 Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset="US-ASCII" Content-Disposition: inline Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 914 Lines: 27 Ingo Molnar writes: > > On Tue, 5 Oct 2004, Con Kolivas wrote: > >> unsigned long long delta = now - next->timestamp; >> >> if (next->activated == 1) >> delta = delta * (ON_RUNQUEUE_WEIGHT * 128 / 100) / 128; >> >> is in schedule() before we update the timestamp, no? > > indeed ... so the patch is just random incorrect damage that happened to > distrub the scheduler fixing some balancing problem. Kenneth, what > precisely is the balancing problem you are seeing? We used to compare jiffy difference in can_migrate_task by comparing it to cache_decay_ticks. Somewhere in the merging of sched_domains it was changed to task_hot which uses timestamp. Con - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/