Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268902AbUJEHKV (ORCPT ); Tue, 5 Oct 2004 03:10:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268900AbUJEHKT (ORCPT ); Tue, 5 Oct 2004 03:10:19 -0400 Received: from mx1.redhat.com ([66.187.233.31]:28640 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S268902AbUJEHKG (ORCPT ); Tue, 5 Oct 2004 03:10:06 -0400 Date: Tue, 5 Oct 2004 03:09:31 -0400 (EDT) From: Ingo Molnar X-X-Sender: mingo@devserv.devel.redhat.com To: Con Kolivas cc: =?ISO-8859-1?B?Q2hlbiw=?= Kenneth W , linux-kernel@vger.kernel.org, Andrew Morton , Nick Piggin Subject: Re: bug in sched.c:activate_task() In-Reply-To: Message-ID: References: <200410050216.i952Gb620657@unix-os.sc.intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1085 Lines: 30 On Tue, 5 Oct 2004, Con Kolivas wrote: > We used to compare jiffy difference in can_migrate_task by comparing it > to cache_decay_ticks. Somewhere in the merging of sched_domains it was > changed to task_hot which uses timestamp. yep, that's fishy. Kenneth, could you try the simple patch below? It gets rid of task_hot() in essence. If this works out we could try it - it gets rid of some more code from sched.c too. Perhaps SD_WAKE_AFFINE is enough control. Ingo --- kernel/sched.c.orig 2004-10-05 08:28:42.295395160 +0200 +++ kernel/sched.c 2004-10-05 09:07:44.081389576 +0200 @@ -180,7 +180,7 @@ static unsigned int task_timeslice(task_ else return SCALE_PRIO(DEF_TIMESLICE, p->static_prio); } -#define task_hot(p, now, sd) ((now) - (p)->timestamp < (sd)->cache_hot_time) +#define task_hot(p, now, sd) 0 enum idle_type { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/