Date: Tue, 5 Oct 2004 19:25:22 +0200
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
       Russell King <rmk@arm.linux.org.uk>, sebastien.hinderer@libertysurf.fr
Subject: Re: [Patch] new serial flow control
Message-ID: <20041005172522.GA2264@bouh.is-a-geek.org>
Mail-Followup-To: Chuck Ebbert <76306.1226@compuserve.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Russell King <rmk@arm.linux.org.uk>,
	sebastien.hinderer@libertysurf.fr
References: <200410051249_MC3-1-8B8B-5504@compuserve.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <200410051249_MC3-1-8B8B-5504@compuserve.com>
User-Agent: Mutt/1.5.6i-nntp
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1648
Lines: 36

Le mar 05 oct 2004 ? 12:46:34 -0400, Chuck Ebbert a tapot? sur son clavier :
> Samual Thibault wrote:
> 
> >+      } else if (info->flags & ASYNC_TVB_FLOW) {
> >+              if (status & UART_MSR_CTS) {
> >+                      if (!(info->MCR & UART_MCR_RTS)) {
> >+                              /* start of TVB frame, raise RTS to greet data */
> >+                              info->MCR |= UART_MCR_RTS;
> >+                              serial_out(info, UART_MCR, info->MCR);
> >+#if (defined(SERIAL_DEBUG_INTR) || defined(SERIAL_DEBUG_FLOW))
> >+                              printk("TVB frame start...");
> >+#endif
> >+                      }
> >+              } else {
> >+                      if (info->MCR & UART_MCR_RTS) {
> >+                              /* CTS went down, lower RTS as well */
> >+                              info->MCR &= ~UART_MCR_RTS;
> >+                              serial_out(info, UART_MCR, info->MCR);
> >+#if (defined(SERIAL_DEBUG_INTR) || defined(SERIAL_DEBUG_FLOW))
> >+                              printk("TVB frame started...");
> >+#endif
>                                                   ^^^^^^^
> 
> Shouldn't this be "ended"? ... or "end" since frame begin msg says "start"
> i.e. is not past tense?

No: data actually pass _after_ CTS and RTS are lowered back: the flow control
only indicate the beginning of one frame.

Regards,
Samuel Thibault
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/