Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269218AbUJFMPm (ORCPT ); Wed, 6 Oct 2004 08:15:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269225AbUJFMPl (ORCPT ); Wed, 6 Oct 2004 08:15:41 -0400 Received: from mail.fh-wedel.de ([213.39.232.198]:37612 "EHLO moskovskaya.fh-wedel.de") by vger.kernel.org with ESMTP id S269218AbUJFMPj (ORCPT ); Wed, 6 Oct 2004 08:15:39 -0400 Date: Wed, 6 Oct 2004 14:15:34 +0200 From: =?iso-8859-1?Q?J=F6rn?= Engel To: Geert Uytterhoeven Cc: Willy Tarreau , Denis Vlasenko , Linux Kernel Development Subject: Re: [PATCH] Console: fall back to /dev/null when no console is availlable Message-ID: <20041006121534.GA8386@wohnheim.fh-wedel.de> References: <20041005185214.GA3691@wohnheim.fh-wedel.de> <200410060058.57244.vda@port.imtp.ilyichevsk.odessa.ua> <20041006043458.GB19761@alpha.home.local> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.3.28i X-SA-Exim-Scanned: No; SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1495 Lines: 37 On Wed, 6 October 2004 10:43:52 +0200, Geert Uytterhoeven wrote: > On Wed, 6 Oct 2004, Willy Tarreau wrote: > > On Wed, Oct 06, 2004 at 12:58:57AM +0300, Denis Vlasenko wrote: > > > > + if (open("/dev/null", O_RDWR, 0) == 0) > > > > + printk(" Falling back to /dev/null.\n"); > > > > + } > > > > > > What will happen if /dev is totally empty? > > > > ... Which is the most probable reason causing this trouble. I have no idea about the probability, but in the one case I worry about, a console is explicitly disabled because it is not wanted. /dev does exist and is populated. > Some debug methods use register_console() to get their print routines > registered. If people forget to say e.g. `console=tty0' afterwards, the debug > console without the real device cannot be opened through /dev/console, and they > get a mysterious error. Usually /dev/console _is_ present in the root fs. Yes, I thought about doing things at a different level as well. If there really is no console, shouldn't /dev/console have the same behavious as /dev/null? Point is that above patch is simpler and empiria didn't give me a reason to worry about anything else. J?rn -- Time? What's that? Time is only worth what you do with it. -- Theo de Raadt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/