Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269337AbUJGEXO (ORCPT ); Thu, 7 Oct 2004 00:23:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269685AbUJGEXO (ORCPT ); Thu, 7 Oct 2004 00:23:14 -0400 Received: from linux.us.dell.com ([143.166.224.162]:32370 "EHLO lists.us.dell.com") by vger.kernel.org with ESMTP id S269337AbUJGEXI (ORCPT ); Thu, 7 Oct 2004 00:23:08 -0400 Date: Wed, 6 Oct 2004 23:22:54 -0500 From: Matt Domsch To: Andrew Morton Cc: Jeff Garzik , linux-kernel@vger.kernel.org, alan@redhat.com, david.balazic@hermes.si Subject: Re: [PATCH 2.6.9-rc3-mm2] EDD: use EXTENDED READ command, add CONFIG_EDD_SKIP_MBR Message-ID: <20041007042254.GA7325@lists.us.dell.com> References: <20041004214803.GC2989@lists.us.dell.com> <4164BF82.2040608@pobox.com> <20041006211605.17c1cb41.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041006211605.17c1cb41.akpm@osdl.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1246 Lines: 38 On Wed, Oct 06, 2004 at 09:16:05PM -0700, Andrew Morton wrote: > Jeff Garzik wrote: > > > > > This also adds CONFIG_EDD_SKIP_MBR to eliminate reading the MBR on > > > each BIOS-presented disk, in case there are further problems in this > > > area. > > > > > > Build fails on x86-64: > > > > [...] > > SYSMAP System.map > > SYSMAP .tmp_System.map > > AS arch/x86_64/boot/setup.o > > In file included from arch/x86_64/boot/setup.S:536: > > arch/i386/boot/edd.S:17: macro names must be identifiers > > make[1]: *** [arch/x86_64/boot/setup.o] Error 1 > > make: *** [bzImage] Error 2 > > hm, works OK here. > > Is it missing config.h? No, that's pulled in by setup.S which #includes edd.S, on both i386 and x86_64. Jeff, is it the parens around CONFIG_EDD_SKIP_MBR on that line somehow? -- Matt Domsch Sr. Software Engineer, Lead Engineer Dell Linux Solutions linux.dell.com & www.dell.com/linux Linux on Dell mailing lists @ http://lists.us.dell.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/