Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269774AbUJGKQC (ORCPT ); Thu, 7 Oct 2004 06:16:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269779AbUJGKQB (ORCPT ); Thu, 7 Oct 2004 06:16:01 -0400 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:11790 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S269774AbUJGKPw (ORCPT ); Thu, 7 Oct 2004 06:15:52 -0400 Date: Thu, 7 Oct 2004 11:15:41 +0100 From: Russell King To: Jesper Juhl Cc: Andrew Morton , linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: 2.6.9-rc3-mm3 Message-ID: <20041007111541.D10716@flint.arm.linux.org.uk> Mail-Followup-To: Jesper Juhl , Andrew Morton , linux-kernel@vger.kernel.org, Christoph Hellwig References: <20041007015139.6f5b833b.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from juhl-lkml@dif.dk on Thu, Oct 07, 2004 at 12:04:22PM +0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 825 Lines: 19 On Thu, Oct 07, 2004 at 12:04:22PM +0200, Jesper Juhl wrote: > After recieving some feedback from Christoph Hellwig I believe this is > probably a better version of the patch (no reason not to use the > access_ok checking version of copy_to_user) : Except that we've validated the user pointer _before_ performing any of the ioctl handling itself, so the non-__ copy_to_user is fairly redundant. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/