Date: Thu, 7 Oct 2004 13:05:30 -0700
From: Andrew Morton <akpm@osdl.org>
To: Chris Wright <chrisw@osdl.org>
Cc: serue@us.ibm.com, chrisw@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 2/3] lsm: add bsdjail module
Message-Id: <20041007130530.5bcffa3c.akpm@osdl.org>
In-Reply-To: <20041007124221.D2357@build.pdx.osdl.net>
References: <1097094103.6939.5.camel@serge.austin.ibm.com>
	<1097094270.6939.9.camel@serge.austin.ibm.com>
	<20041006162620.4c378320.akpm@osdl.org>
	<20041007190157.GA3892@IBM-BWN8ZTBWA01.austin.ibm.com>
	<20041007124221.D2357@build.pdx.osdl.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1184
Lines: 30

Chris Wright <chrisw@osdl.org> wrote:
>
> * Serge E. Hallyn (serue@us.ibm.com) wrote:
> > Attached is a new version of the bsdjail patch with the requested code
> > cleanups applied.
> 
> I noticed Andrew picked this up in -mm3, but that he had to do some diff
> cleanups (see the thread/rlim changes in his tree).  If you'd like Andrew
> to pick this up, it would be courteous to get the diff clean and
> building against his tree.

Nah, that's OK.  I can drop the old patch and pick up the new.

It's only when code is settling down into a final state that I get upset
about wholesale replacements.  Even then I'll just feed it through
interdiff.

> Andrew has cleanup here (__FUNCTION__ ,).  I just use __func__, anyway.

That's a workaround for the gcc-2.95 pasting bug.

__FUNCTION__ is preferred, actually.  Just for consistency, and so the
compiler will spit it out if someone tries to do compile-time string
concatenation with it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/