Date: Thu, 07 Oct 2004 21:25:41 +0000
From: "J.A. Magallon" <jamagallon@able.es>
Subject: Re: 2.6.9-rc3-mm3
To: William Lee Irwin III <wli@holomorphy.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
References: <20041007015139.6f5b833b.akpm@osdl.org>
	<200410071041.20723.sandersn@btinternet.com>
	<20041007025007.77ec1a44.akpm@osdl.org>
	<20041007114040.GV9106@holomorphy.com>
In-Reply-To: <20041007114040.GV9106@holomorphy.com> (from wli@holomorphy.com
	on Thu Oct  7 13:40:40 2004)
Message-Id: <1097184341l.10532l.0l@werewolf.able.es>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
	Format=Flowed
Content-Disposition: inline
Content-Transfer-Encoding: 7BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1619
Lines: 49


On 2004.10.07, William Lee Irwin III wrote:
> Nick Sanders <sandersn@btinternet.com> wrote:
> >> I get the following oops when booting and it also stops kde
> >> (artswrapper) from starting with the same call trace. USB seems to
> >> be working which is good.
> 
> On Thu, Oct 07, 2004 at 02:50:07AM -0700, Andrew Morton wrote:
> > Could you please do
> > cd /usr/src/linux
> > wget ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.9-rc3/2.6.9-rc3-mm3/broken-out/optimize-profile-path-slightly.patch
> > patch -R -p1 < optimize-profile-path-slightly.patch
> > and retest?
...
> 
> Here is a more likely correct patch for what that was trying to do,
> however misguided that may be. Untested, uncompiled, vs. 2.6.9-rc3-mm3
> without the bad patch:
> 
...
> +static inline void profile_tick(int type, struct pt_regs *regs)
> +{
> +	extern cpumask_t prof_cpu_mask;
> +

This conflicts with kernel/irq/proc.c:

	unsigned long prof_cpu_mask = -1;

Shouldn't this be:

	cpumask_t prof_cpu_mask = CPU_MASK_NONE;

This will show problems when NR_CPUS > sizeof(long)....

Hope this helps.

--
J.A. Magallon <jamagallon()able!es>     \               Software is like sex:
werewolf!able!es                         \         It's better when it's free
Mandrakelinux release 10.1 (Community) for i586
Linux 2.6.9-rc3-mm2 (gcc 3.4.1 (Mandrakelinux 10.1 3.4.1-4mdk)) #2


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/