Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S270022AbUJHPqQ (ORCPT ); Fri, 8 Oct 2004 11:46:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S270040AbUJHPoC (ORCPT ); Fri, 8 Oct 2004 11:44:02 -0400 Received: from colin2.muc.de ([193.149.48.15]:13833 "HELO colin2.muc.de") by vger.kernel.org with SMTP id S270022AbUJHPm2 (ORCPT ); Fri, 8 Oct 2004 11:42:28 -0400 Date: 8 Oct 2004 17:42:27 +0200 Date: Fri, 8 Oct 2004 17:42:27 +0200 From: Andi Kleen To: Denis Vlasenko Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] Make gcc -align options .config-settable Message-ID: <20041008154227.GA91816@muc.de> References: <2KBq9-2S1-15@gated-at.bofh.it> <200410081710.58766.vda@port.imtp.ilyichevsk.odessa.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410081710.58766.vda@port.imtp.ilyichevsk.odessa.ua> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1491 Lines: 40 On Fri, Oct 08, 2004 at 05:10:58PM +0000, Denis Vlasenko wrote: > On Friday 08 October 2004 12:20, Andi Kleen wrote: > > Denis Vlasenko writes: > > > Resend. > > > > > > With all alignment options set to 1 (minimum alignment), > > > I've got 5% smaller vmlinux compared to one built with > > > default code alignment. > > > > > > Rediffed against 2.6.9-rc3. > > > Please apply. > > > > I agree with the basic idea (the big alignments also always annoy > > me when I look at disassembly), but I think your CONFIG options > > are far too complicated. I don't think anybody will go as far as > > to tune loops vs function calls. > > > > I would just do a single CONFIG_NO_ALIGNMENTS that sets everything to > > 1, that should be enough. > > For me, yes, but there are people which are slightly less obsessed > with code size than me. > > They might want to say "try to align to 16 bytes if > it costs less than 5 bytes" etc. If they want to go down to that low level they can as well edit the Makefiles. But we already have far too many configs and adding new ones for obscure compiler options is not a good idea. Also we don't normally add stuff "just in case", but only when people actually use it. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/