Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266233AbUJIChb (ORCPT ); Fri, 8 Oct 2004 22:37:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266236AbUJIChb (ORCPT ); Fri, 8 Oct 2004 22:37:31 -0400 Received: from wombat.indigo.net.au ([202.0.185.19]:2828 "EHLO wombat.indigo.net.au") by vger.kernel.org with ESMTP id S266233AbUJICh3 (ORCPT ); Fri, 8 Oct 2004 22:37:29 -0400 Date: Sat, 9 Oct 2004 10:22:20 +0800 (WST) From: raven@themaw.net To: Valdis.Kletnieks@vt.edu cc: Denis Vlasenko , LKML Subject: Re: [PATCH] make automounter runnable in foreground and add stderr logging In-Reply-To: <200410071817.i97IHnPZ017247@turing-police.cc.vt.edu> Message-ID: References: <200410072049.18059.vda@port.imtp.ilyichevsk.odessa.ua> <200410071817.i97IHnPZ017247@turing-police.cc.vt.edu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-MailScanner: Found to be clean X-MailScanner-SpamCheck: not spam, SpamAssassin (score=-101.7, required 8, EMAIL_ATTRIBUTION, IN_REP_TO, NO_REAL_NAME, QUOTED_EMAIL_TEXT, REFERENCES, REPLY_WITH_QUOTES, USER_AGENT_PINE, USER_IN_WHITELIST) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1112 Lines: 31 On Thu, 7 Oct 2004 Valdis.Kletnieks@vt.edu wrote: > On Thu, 07 Oct 2004 20:49:17 +0300, Denis Vlasenko said: > > > PS: is there a reason why automount does this? > > > > /* include/config.h. Generated by configure. */ > > #define PATH_MOUNT "/usr/bin/mount" > > #define PATH_UMOUNT "/usr/bin/umount" > > #define PATH_E2FSCK "/usr/bin/fsck.ext2" > > #define PATH_E3FSCK "/usr/bin/fsck.ext3" > > > > We have $PATH for ages... > > Yes, and sometimes you specifically want to make sure you pick up the > right official binary, and not some other one that happens to be in $PATH. > If somebody manages to get automount launched with an insecure $PATH, you > could end up invoking a trojaned mount command (remember why "." in $PATH > is a security issue....) > And that would be the point of using configure to find this path info. rather than using $PATH. Ian - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/