Date: Sat, 9 Oct 2004 14:18:45 +0200
From: Gerd Knorr <kraxel@bytesex.org>
To: Michael Geng <linux@MichaelGeng.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: video_usercopy() enforces change of VideoText IOCTLs since 2.6.8
Message-ID: <20041009121845.GE3482@bytesex>
References: <20041007165410.GA2306@t-online.de> <20041008105219.GA24842@bytesex> <20041008140056.72b177d9.akpm@osdl.org> <20041009092801.GC3482@bytesex> <20041009112839.GA2908@t-online.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20041009112839.GA2908@t-online.de>
User-Agent: Mutt/1.5.6i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 915
Lines: 25

> I would prefer redefining them with respect
> to the arguments passed to the IOCTLs.

Thats possible as well.

> Nevertheless there is one big disadvantage: The userspace programs 
> have to be recompiled because they of course have to use the same IOCTL 
> definitions. 

You can just keep the old ones and map them, so both old and new ones
will work (and internally only the new ones are used).
video_fix_command() does that for a number of v4l2 ioctls which
initially got a _IO* define with wrong read/write bits.  You can either
just add the videotext ones there or translate them in the drivers right
before calling video_usercopy().

  Gerd

-- 
return -ENOSIG;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/