Date: Sat, 9 Oct 2004 19:18:59 +0100
From: Matthew Wilcox <matthew@wil.cx>
To: Scott Feldman <sfeldma@pobox.com>
Cc: Hanna Linder <hannal@us.ibm.com>,
       kernel-janitors <kernel-janitors@lists.osdl.org>, ak@suse.de,
       lkml <linux-kernel@vger.kernel.org>, greg@kroah.com
Subject: Re: [KJ] [RFT 2.6] pci-gart.c replace pci_find_device with pci_get_device
Message-ID: <20041009181859.GW16153@parcelfarce.linux.theplanet.co.uk>
References: <87680000.1097276112@w-hlinder.beaverton.ibm.com> <1097342134.3903.14.camel@sfeldma-mobl2.dsl-verizon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1097342134.3903.14.camel@sfeldma-mobl2.dsl-verizon.net>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1284
Lines: 28

On Sat, Oct 09, 2004 at 10:15:34AM -0700, Scott Feldman wrote:
> On Fri, 2004-10-08 at 15:55, Hanna Linder wrote:
> > @@ -81,7 +81,7 @@ static u32 gart_unmapped_entry; 
> >  
> >  #define for_all_nb(dev) \
> >  	dev = NULL;	\
> > -	while ((dev = pci_find_device(PCI_VENDOR_ID_AMD, 0x1103, dev))!=NULL)\
> > +	while ((dev = pci_get_device(PCI_VENDOR_ID_AMD, 0x1103, dev))!=NULL)\
> >  	     if (dev->bus->number == 0 && 				     \
> >  		    (PCI_SLOT(dev->devfn) >= 24) && (PCI_SLOT(dev->devfn) <= 31))
> 
> for_each_pci_dev?

for_each_pci_dev() doesn't take a VENDOR/DEVICE ID pair.
I think this is a mistake.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/