Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268680AbUJKEIx (ORCPT ); Mon, 11 Oct 2004 00:08:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268682AbUJKEIx (ORCPT ); Mon, 11 Oct 2004 00:08:53 -0400 Received: from fw.osdl.org ([65.172.181.6]:29126 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S268680AbUJKEIu (ORCPT ); Mon, 11 Oct 2004 00:08:50 -0400 Date: Sun, 10 Oct 2004 21:08:48 -0700 (PDT) From: Linus Torvalds To: Benjamin Herrenschmidt cc: Linux Kernel list , Andrew Morton , Pavel Machek , David Brownell , Paul Mackerras Subject: Re: Totally broken PCI PM calls In-Reply-To: <1097466354.3539.14.camel@gaston> Message-ID: References: <1097455528.25489.9.camel@gaston> <1097466354.3539.14.camel@gaston> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1094 Lines: 29 On Mon, 11 Oct 2004, Benjamin Herrenschmidt wrote: > > Disagreed. Sorry, but can you give me a good example ? The drivers still > do the broken assumptions of passing directly the state parameter to > pci_set_power_state() (or whatever we call this one these days) but this > is worked around by defining PM_SUSPEND_MEM to 3 in pm.h. .. take a look at PM_SUSPEND_DISK for a moment. If you only care about PM_SUSPEND_MEM, then what's your problem? You get the right value already. And if you _do_ care about PM_SUSPEND_DISK, then don't ignore it in the discussion. You can't have it both ways. The fact is, my laptop can now (finally) do suspend-to-disk. It never could do that before. And yes, it does use radeonfb, so your arguments hold no water with me. I told you what can done to fix things up. Stop ignoring that reality. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/