Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268873AbUJKMaE (ORCPT ); Mon, 11 Oct 2004 08:30:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268878AbUJKMaE (ORCPT ); Mon, 11 Oct 2004 08:30:04 -0400 Received: from port-212-202-157-208.static.qsc.de ([212.202.157.208]:59853 "EHLO zoidberg.portrix.net") by vger.kernel.org with ESMTP id S268873AbUJKMaA (ORCPT ); Mon, 11 Oct 2004 08:30:00 -0400 Message-ID: <416A7CB3.9000003@portrix.net> Date: Mon, 11 Oct 2004 14:29:39 +0200 From: Jan Dittmer User-Agent: Mozilla Thunderbird 0.8 (X11/20040918) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Cal Peake CC: Kernel Mailing List , NetDev Mailing List , proski@gnu.org, hermes@gibson.dropbear.id.au Subject: Re: [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h References: <416A7484.1030703@portrix.net> In-Reply-To: X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 951 Lines: 30 Cal Peake wrote: > On Mon, 11 Oct 2004, Jan Dittmer wrote: > > >>Cal Peake wrote: >> >> >>> inw((hw)->iobase + ( (off) << (hw)->reg_spacing )) : \ >>>- readw((hw)->iobase + ( (off) << (hw)->reg_spacing ))) >>>+ readw((void __iomem *)(hw)->iobase + ( (off) << (hw)->reg_spacing ))) >>> #define hermes_write_reg(hw, off, val) do { \ >> >>Isn't the correct fix to declare iobase as (void __iomem *) ? > > > iobase is an unsigned long, declaring it as a void pointer is prolly not > what we want to do here. The typecast seems proper. A lot of other drivers > do this as well thus it must be proper ;-) Why is iobase a unsigned long in the first place? Isn't this broken for 64bit archs? Thanks, Jan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/