Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268981AbUJKOFI (ORCPT ); Mon, 11 Oct 2004 10:05:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268987AbUJKOFH (ORCPT ); Mon, 11 Oct 2004 10:05:07 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:52877 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S268981AbUJKOE4 (ORCPT ); Mon, 11 Oct 2004 10:04:56 -0400 Date: Mon, 11 Oct 2004 15:04:54 +0100 From: viro@parcelfarce.linux.theplanet.co.uk To: Pavel Roskin Cc: Cal Peake , linux-kernel@vger.kernel.org, netdev@oss.sgi.com, David Gibson Subject: Re: [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h Message-ID: <20041011140454.GW23987@parcelfarce.linux.theplanet.co.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 739 Lines: 20 On Mon, Oct 11, 2004 at 09:12:03AM -0400, Pavel Roskin wrote: > Another, more sophisticated solution would be to use union for iobase: > > typedef struct hermes { > union { > unsigned long io; > void *mem; > } base; > int io_space; /* 1 if we IO-mapped IO, 0 for memory-mapped IO? */ > ... > } Not needed. Use ioread*/iowrite* family; it does what you need. Al, putting together a patchset and documention on that sort of cleanups... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/