Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269563AbUJLJfr (ORCPT ); Tue, 12 Oct 2004 05:35:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269578AbUJLJfr (ORCPT ); Tue, 12 Oct 2004 05:35:47 -0400 Received: from mail.renesas.com ([202.234.163.13]:17536 "EHLO mail04.idc.renesas.com") by vger.kernel.org with ESMTP id S269563AbUJLJfW (ORCPT ); Tue, 12 Oct 2004 05:35:22 -0400 Date: Tue, 12 Oct 2004 18:35:07 +0900 (JST) Message-Id: <20041012.183507.350531171.takata.hirokazu@renesas.com> To: Bernd Eckenfels Cc: linux-kernel@vger.kernel.org, takata@linux-m32r.org, akpm@osdl.org Subject: Re: [PATCH 2.6.9-rc3-mm2] [m32r] SIO driver for m32r From: Hirokazu Takata In-Reply-To: References: <20041006.151912.840807084.takata.hirokazu@renesas.com> X-Mailer: Mew version 3.3 on XEmacs 21.4.15 (Security Through Obscurity) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 37 Hello, Bernd, From: Bernd Eckenfels Subject: Re: [PATCH 2.6.9-rc3-mm2] [m32r] SIO driver for m32r Date: Wed, 06 Oct 2004 09:47:16 +0200 > In article <20041006.151912.840807084.takata.hirokazu@renesas.com> you wrote: > > +static void sio_error(int *status) > > +{ > > + printk("SIO0 error[%04x]\n", *status); > > + do { > > + sio_init(); > > + } while ((*status = __sio_in(PLD_ESIO0CR)) != 3); > > +} > > is this safe and sane? Wont that lockup the machine on hardware problems? Hmm.. Do you have any good idea to fix it? > It > is also duplicated, with only the port differ. OK. I will try to merge them. > Greetings > Bernd > -- > eckes privat - http://www.eckes.org/ > Project Freefire - http://www.freefire.org/ Thanks. -- Takata - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/