Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266366AbUJLRJe (ORCPT ); Tue, 12 Oct 2004 13:09:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266341AbUJLRHt (ORCPT ); Tue, 12 Oct 2004 13:07:49 -0400 Received: from havoc.gtf.org ([69.28.190.101]:46257 "EHLO havoc.gtf.org") by vger.kernel.org with ESMTP id S266236AbUJLRG3 (ORCPT ); Tue, 12 Oct 2004 13:06:29 -0400 Date: Tue, 12 Oct 2004 13:05:26 -0400 From: Jeff Garzik To: Mark Lord Cc: James Bottomley , Christoph Hellwig , Mark Lord , Linux Kernel , SCSI Mailing List Subject: Re: [PATCH] QStor SATA/RAID driver for 2.6.9-rc3 Message-ID: <20041012170526.GB9274@havoc.gtf.org> References: <4165A85D.7080704@rtr.ca> <4165AB1B.8000204@pobox.com> <4165ACF8.8060208@rtr.ca> <20041007221537.A17712@infradead.org> <1097241583.2412.15.camel@mulgrave> <4166AF2F.6070904@rtr.ca> <1097249266.1678.40.camel@mulgrave> <4166B37D.8030701@rtr.ca> <1097251299.1928.56.camel@mulgrave> <416C0DC5.2080206@rtr.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <416C0DC5.2080206@rtr.ca> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1156 Lines: 35 On Tue, Oct 12, 2004 at 01:00:53PM -0400, Mark Lord wrote: > James Bottomley wrote: > >On Fri, 2004-10-08 at 10:34, Mark Lord wrote: > > > >>If those locks are not needed, the scsi.c maintainer really should > >>nuke'em. > > > >I think you can safely assume he has more important things to do. > > I was actually working on the assumption that the lock might be > there because it is/was necessary for something, like perhaps protecting > access to the add_timer()/del_timer() calls associated with the scmd? > > If not, no issue -- it can be removed from the driver. I'll respectfully disagree with James... I think the most prudent course of action is to follow the example of SCSI common code. If the SCSI core is doing something wrong, we should fix that _first_, not set a precedent of confusing dissociation. Everyone knows that Linux programmers engineer with their cut-n-paste feature. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/