Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266572AbUJLSiX (ORCPT ); Tue, 12 Oct 2004 14:38:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266582AbUJLSiX (ORCPT ); Tue, 12 Oct 2004 14:38:23 -0400 Received: from cpu1185.adsl.bellglobal.com ([207.236.110.166]:39875 "EHLO mail.rtr.ca") by vger.kernel.org with ESMTP id S266572AbUJLSiU (ORCPT ); Tue, 12 Oct 2004 14:38:20 -0400 Message-ID: <416C242E.9010102@rtr.ca> Date: Tue, 12 Oct 2004 14:36:30 -0400 From: Mark Lord User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040913 X-Accept-Language: en, en-us MIME-Version: 1.0 To: James Bottomley Cc: Jeff Garzik , Christoph Hellwig , Mark Lord , Linux Kernel , SCSI Mailing List Subject: Re: [PATCH] QStor SATA/RAID driver for 2.6.9-rc3 References: <4161A06D.8010601@rtr.ca> <416547B6.5080505@rtr.ca> <20041007150709.B12688@i nfradead.org> <4165624C.5060405@rtr.ca> <416565DB.4050006@pobox.com> <416 5 A 4 5D.2090200@rtr.ca> <4165A766.1040104@pobox.com> <4165A85D.7080704@rtr. ca > <4 165AB1B.8000204@pobox.com> <4165ACF8.8060208@rtr.ca> <200410072215 37. A17 712@infradead.org> <1097241583.2412.15.camel@mulgrave> <4166AF2F.60 7090 4@rtr.ca> <1097249266.1678.40.camel@mulgrave> <4166B48E.3020006@rtr.ca> <1097250465.2 412.49.camel@mulgrave> <416C0D55.1020603@rtr.ca> <1097601478.2044.103.camel@mulgrave> <416C12CC.1050301@rtr.ca> <1097602220.2044.119.camel@mulgrave> <416C157A.6030400@rtr.ca> <416C177B.6030504@pobox.com> <416C19B9.7000806@rtr.ca> <1097604730.1763.177.camel@mulgrave> In-Reply-To: <1097604730.1763.177.camel@mulgrave> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 769 Lines: 22 James Bottomley wrote: .. > What you need to do is to gather as much information as will reset the > interrupt and then process the data as a tasklet. For your hotplug > events, they should be fire and forget as schedule_work(). Okay. Good find, thanks. I'll rework that portion to remove the bh handling completely, doing everything possible directly from within the interrupt handler. It will continue to use schedule_work to handle hotplug events. Cheers -- Mark Lord (hdparm keeper & the original "Linux IDE Guy") - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/