Date: Wed, 13 Oct 2004 10:09:29 +0900 (JST)
Message-Id: <20041013.100929.982911309.takata.hirokazu@renesas.com>
To: paul.mundt@nokia.com
Cc: akpm@osdl.org, nico@cam.org, takata@linux-m32r.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: fix smc91x build for sh/ppc
From: Hirokazu Takata <takata.hirokazu@renesas.com>
In-Reply-To: <20041012161631.GA8766@hed040-158.research.nokia.com>
References: <20041012161631.GA8766@hed040-158.research.nokia.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1411
Lines: 40

Hello, Paul,

OK. I agree with you.

From: Paul Mundt <paul.mundt@nokia.com>
Subject: [PATCH] net: fix smc91x build for sh/ppc
Date: Tue, 12 Oct 2004 19:16:32 +0300
> The current smc91x code uses set_irq_type(). It looks like the m32r guys
> worked around this by adding a !defined(__m32r__) check, but this is equally
> bogus as set_irq_type() is an arm/arm26-specific function.
> 
> Trying to get this to build on sh died in the same spot, so we just back out
> the m32r change and make it depend on CONFIG_ARM instead. Notably, the ppc
> build would have been broken by this as well, but it doesn't seem like anyone
> noticed this there yet.
> 
> Signed-off-by: Paul Mundt <paul.mundt@nokia.com>
> 
>  drivers/net/smc91x.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> ===== drivers/net/smc91x.c 1.7 vs edited =====
> --- 1.7/drivers/net/smc91x.c	2004-09-17 03:07:00 +03:00
> +++ edited/drivers/net/smc91x.c	2004-10-12 19:05:25 +03:00
> @@ -1885,7 +1885,7 @@
>        	if (retval)
>        		goto err_out;
>  
> -#if !defined(__m32r__)
> +#ifdef CONFIG_ARM
>  	set_irq_type(dev->irq, IRQT_RISING);
>  #endif
>  #ifdef SMC_USE_PXA_DMA

-- Takata
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/