Date: Thu, 14 Oct 2004 14:54:02 -0400
From: Jeffrey Mahoney <jeffm@csh.rit.edu>
To: Andrew Morton <akpm@osdl.org>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Hans Reiser <reiser@namesys.com>
Subject: [PATCH 0/2] reiserfs: Warn on unsupported options
Message-ID: <20041014185402.GA9619@locomotive.unixthugs.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.6i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1451
Lines: 39

Yes, the subject sounds silly, but it's needed.

The set of allowable mount options shouldn't change based on the running
kernel configuration. The feature that the option corresponds to may be
unavailable, but in many cases it should be sufficient to warn the user that
the feature is disabled, but the mount has succeeded.

Ext3 does this for things like acl/xattr, and I feel that reiserfs should as
well.

Fortunately, the code to implement it is trivial.

In the following two messages are two patches:
* reiserfs-unsupported-opts.diff
   - Adds a REISERFS_UNSUPPORTED_OPT mount flag, and uses it to denote
     when a mount option is allowed, but not supported in the running
     configuration.
   - Rather than setting/clearing this bit, it's treated as special
     and issues a warning using the name of the mount option.
* reiserfs-unsupported-acl.diff
   - Uses the above flag to denote ACLs and user xattrs as unsupported
     when support is not compiled in.

Currently, if a filesystem is mounted with -oacl and they are not
compiled in, the filesystem will fail to mount. With these patches, the options
are ignored with a warning.

Andrew - Please apply.

-Jeff

-- 
Jeff Mahoney
SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/