Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268024AbUJNWmH (ORCPT ); Thu, 14 Oct 2004 18:42:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267916AbUJNWda (ORCPT ); Thu, 14 Oct 2004 18:33:30 -0400 Received: from opersys.com ([64.40.108.71]:2062 "EHLO www.opersys.com") by vger.kernel.org with ESMTP id S268024AbUJNWcz (ORCPT ); Thu, 14 Oct 2004 18:32:55 -0400 Message-ID: <416F0071.3040304@opersys.com> Date: Thu, 14 Oct 2004 18:40:49 -0400 From: Karim Yaghmour Reply-To: karim@opersys.com Organization: Opersys inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 X-Accept-Language: en-us, en, fr, fr-be, fr-ca, fr-fr MIME-Version: 1.0 To: Ingo Molnar CC: linux-kernel@vger.kernel.org, Thomas Zanussi , Robert Wisniewski , Richard J Moore , Michel Dagenais Subject: Re: [patch] Real-Time Preemption, -VP-2.6.9-rc4-mm1-U0 References: <20041011215909.GA20686@elte.hu> <20041012091501.GA18562@elte.hu> <20041012123318.GA2102@elte.hu> <20041012195424.GA3961@elte.hu> <20041013061518.GA1083@elte.hu> <20041014002433.GA19399@elte.hu> In-Reply-To: <20041014002433.GA19399@elte.hu> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 773 Lines: 23 Ingo Molnar wrote: > http://redhat.com/~mingo/voluntary-preempt/voluntary-preempt-2.6.9-rc4-mm1-U0 I notice: + local_irq_save(flags); + ____trace(&__get_cpu_var(trace), eip, parent_eip); + local_irq_restore(flags); Why not use the lockless logging available in relayfs, you'll avoid the interrupt disabling altogether since, umm ... it's lockless. Karim -- Author, Speaker, Developer, Consultant Pushing Embedded and Real-Time Linux Systems Beyond the Limits http://www.opersys.com || karim@opersys.com || 1-866-677-4546 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/