Subject: Re: [STACK] >3k call path in ide
From: Rusty Russell <rusty@rustcorp.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: =?ISO-8859-1?Q?J=F6rn?= Engel <joern@wohnheim.fh-wedel.de>,
       michael@metaparadigm.com,
       lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
       hugh@veritas.com
In-Reply-To: <20040610161021.7997ad9d.akpm@osdl.org>
References: <20040609122921.GG21168@wohnheim.fh-wedel.de>
	 <40C72B68.1030404@metaparadigm.com>
	 <20040609162949.GC29531@wohnheim.fh-wedel.de>
	 <20040609122721.0695cf96.akpm@osdl.org>
	 <20040610225938.GF3340@wohnheim.fh-wedel.de>
	 <20040610161021.7997ad9d.akpm@osdl.org>
Content-Type: text/plain; charset=iso-8859-1
Message-Id: <1097805499.22673.65.camel@localhost.localdomain>
Mime-Version: 1.0
Date: Fri, 15 Oct 2004 11:58:19 +1000
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1104
Lines: 40

On Fri, 2004-06-11 at 09:10, Andrew Morton wrote:
> J?rn Engel <joern@wohnheim.fh-wedel.de> wrote:
> >
> > read_page_state doesn't exist in 2.6.7-rc3 or 2.6.6-mm5.  How is it
> > defined?
> 
> It was in 2.6.7-rc3-mm1.
> 
> 
> 
> struct page_state is large (148 bytes) and we put them on the stack in awkward
> code paths (page reclaim...)
> 
> So implement a simple read_page_state() which can be used to pluck out a
> single member from the all-cpus page_state accumulators.
> 
> Signed-off-by: Andrew Morton <akpm@osdl.org>
...
> +unsigned long __read_page_state(unsigned offset)
> +{
> +	unsigned long ret = 0;
> +	int cpu;
> +
> +	for (cpu = 0; cpu < NR_CPUS; cpu++) {
> +		unsigned long in;
> +
> +		if (!cpu_possible(cpu))
> +			continue;

for_each_cpu(cpu) here perhaps?

Rusty.
-- 
Anyone who quotes me in their signature is an idiot -- Rusty Russell

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/