Date: Fri, 15 Oct 2004 13:06:48 -0400
From: Chuck Ebbert <76306.1226@compuserve.com>
Subject: Re: janitoring printk with no KERN_ constants, kill all
  defaults?
To: Dave Jones <davej@redhat.com>
Cc: Daniele Pizzoni <auouo@tin.it>,
       linux-kernel <linux-kernel@vger.kernel.org>
Message-ID: <200410151311_MC3-1-8C48-9C05@compuserve.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	 charset=us-ascii
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 774
Lines: 26

Dave Jones wrote:

> Consider this..
>
>       printk (KERN_INFO "blah blah ");
>       if (foo)
>               printk ("%s", stringptr);
>       else
>               printk ("%d", number);
>       printk ("\n");
>
> There's nothing wrong with any of those printk's, so you
> cannot do the checks you mention above.

  But other code can call printk in between on SMP and/or preempt systems,
making a mess of the log.  This is a(n old) problem that should be
fixed once and for all, AFAIC.


--Chuck Ebbert  15-Oct-04  13:05:20
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/