Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267335AbUJRT0K (ORCPT ); Mon, 18 Oct 2004 15:26:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267505AbUJRT0J (ORCPT ); Mon, 18 Oct 2004 15:26:09 -0400 Received: from mx1.elte.hu ([157.181.1.137]:2244 "EHLO mx1.elte.hu") by vger.kernel.org with ESMTP id S267556AbUJRTXB (ORCPT ); Mon, 18 Oct 2004 15:23:01 -0400 Date: Mon, 18 Oct 2004 21:24:19 +0200 From: Ingo Molnar To: "K.R. Foley" Cc: Mark_H_Johnson@raytheon.com, linux-kernel@vger.kernel.org, Lee Revell , Rui Nuno Capela , Bill Huey , Adam Heath , Florian Schmidt Subject: Re: [patch] Real-Time Preemption, -RT-2.6.9-rc4-mm1-U5 Message-ID: <20041018192419.GA7076@elte.hu> References: <20041018165416.GA31259@elte.hu> <4173F879.40102@cybsft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4173F879.40102@cybsft.com> User-Agent: Mutt/1.4.1i X-ELTE-SpamVersion: MailScanner 4.31.6-itk1 (ELTE 1.2) SpamAssassin 2.63 ClamAV 0.73 X-ELTE-VirusStatus: clean X-ELTE-SpamCheck: no X-ELTE-SpamCheck-Details: score=-4.9, required 5.9, autolearn=not spam, BAYES_00 -4.90 X-ELTE-SpamLevel: X-ELTE-SpamScore: -4 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1101 Lines: 35 * K.R. Foley wrote: > Well you just beat me with that one. :) And here is another for > aha152x. > - DECLARE_MUTEX_LOCKED(sem); > + DECLARE_MUTEX(sem); almost - the full patch is the one below. (DECLARE_MUTEX() initializes the mutex as unlocked, so there's a difference.) Ingo --- linux/drivers/scsi/aha152x.c.orig +++ linux/drivers/scsi/aha152x.c @@ -1160,11 +1160,12 @@ static void timer_expired(unsigned long static int aha152x_device_reset(Scsi_Cmnd * SCpnt) { struct Scsi_Host *shpnt = SCpnt->device->host; - DECLARE_MUTEX_LOCKED(sem); + DECLARE_MUTEX(sem); struct timer_list timer; int ret, issued, disconnected; unsigned long flags; + init_MUTEX_LOCKED(&sem); #if defined(AHA152X_DEBUG) if(HOSTDATA(shpnt)->debug & debug_eh) { printk(INFO_LEAD "aha152x_device_reset(%p)", CMDINFO(SCpnt), SCpnt); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/