Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267807AbUJRXl4 (ORCPT ); Mon, 18 Oct 2004 19:41:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267829AbUJRXl4 (ORCPT ); Mon, 18 Oct 2004 19:41:56 -0400 Received: from waste.org ([209.173.204.2]:48515 "EHLO waste.org") by vger.kernel.org with ESMTP id S267807AbUJRXly (ORCPT ); Mon, 18 Oct 2004 19:41:54 -0400 Date: Mon, 18 Oct 2004 18:41:27 -0500 From: Matt Mackall To: Mingming Cao Cc: akpm@osdl.org, "Stephen C. Tweedie" , Badari Pulavarty , linux-kernel , "ext2-devel@lists.sourceforge.net" Subject: Re: [PATCH 1/3] ext3 reservation remove stale window fix Message-ID: <20041018234126.GB28904@waste.org> References: <1098140107.8803.1062.camel@w-ming2.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1098140107.8803.1062.camel@w-ming2.beaverton.ibm.com> User-Agent: Mutt/1.3.28i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 898 Lines: 20 On Mon, Oct 18, 2004 at 03:55:04PM -0700, Mingming Cao wrote: > > Before we changed the per-filesystem reservations from a linked list > to a red-black tree, in order to speed up the linear search from the > list head, we keep the current(stale) reservation window as a > reference pointer to skip the nodes prior to the current/stale > window node, when failed to allocate a new window in current group > and try to do allocation in next group. One wonders whether a prio tree of the sort used by the current VMA searching code would be a better match to the problem than the red-black approach. -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/