Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269049AbUJSIH2 (ORCPT ); Tue, 19 Oct 2004 04:07:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268301AbUJSIH2 (ORCPT ); Tue, 19 Oct 2004 04:07:28 -0400 Received: from ns.virtualhost.dk ([195.184.98.160]:7648 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S268232AbUJSIHW (ORCPT ); Tue, 19 Oct 2004 04:07:22 -0400 Date: Tue, 19 Oct 2004 10:03:13 +0200 From: Jens Axboe To: Linus Torvalds Cc: Ben Collins , Kernel Mailing List , Dmitry Torokhov , James Bottomley , Andrew Morton , SCSI Mailing List , willy@debian.org, Linux1394-Devel Subject: Re: [BK PATCH] SCSI updates for 2.6.9 Message-ID: <20041019080313.GP2284@suse.de> References: <1098137016.2011.339.camel@mulgrave> <200410182341.13648.dtor_core@ameritech.net> <200410190012.28071.dtor_core@ameritech.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 710 Lines: 21 On Tue, Oct 19 2004, Linus Torvalds wrote: > > Ben, > does this look ok to you? > > Arguably the SCSI layer should also have proper prefixes for its constants > - and in fact they do kind of exist as the GPCMD_xxx constants. Oh, well. > Regardless, the sbp2 constants do look like they want prefixing.. But only for commands (GPCMD is general packet command), not for anything else. Would be nice to standardize prefixes for other things, too. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/