Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269499AbUJSQUl (ORCPT ); Tue, 19 Oct 2004 12:20:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269576AbUJSQTb (ORCPT ); Tue, 19 Oct 2004 12:19:31 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:58764 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S268448AbUJSQR2 (ORCPT ); Tue, 19 Oct 2004 12:17:28 -0400 Date: Tue, 19 Oct 2004 17:17:23 +0100 From: Matthew Wilcox To: James Bottomley Cc: Linus Torvalds , Ben Collins , Kernel Mailing List , Dmitry Torokhov , Andrew Morton , SCSI Mailing List , willy@debian.org, Linux1394-Devel Subject: Re: [BK PATCH] SCSI updates for 2.6.9 Message-ID: <20041019161723.GO16153@parcelfarce.linux.theplanet.co.uk> References: <1098137016.2011.339.camel@mulgrave> <200410182341.13648.dtor_core@ameritech.net> <200410190012.28071.dtor_core@ameritech.net> <1098194090.1714.3.camel@mulgrave> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1098194090.1714.3.camel@mulgrave> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1432 Lines: 29 On Tue, Oct 19, 2004 at 08:54:43AM -0500, James Bottomley wrote: > The condition codes are all migrating to SAM_STAT_ prefix, so > CHECK_CONDITION becomes SAM_STAT_CHECK_CONDITION (and gets shifted in > the process). > > We still have a nasty namespace pollution problem on the SCSI commands > though and cleaning this up is problematic since they permeate not just > SCSI but large areas of other drivers as well. How would you feel about COMMAND_COMPLETE -> SPI_MSG_COMMAND_COMPLETE, possibly even turning them into an enum, and putting them in the new file ? That would get us out of the problems with SBP defining different numbers for the same constants. sbp2 (a) wouldn't include and (b) would use an SBP_MSG_ prefix anyway -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/