Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269963AbUJSXBn (ORCPT ); Tue, 19 Oct 2004 19:01:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S270042AbUJSWms (ORCPT ); Tue, 19 Oct 2004 18:42:48 -0400 Received: from cantor.suse.de ([195.135.220.2]:55701 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S270044AbUJSWkB (ORCPT ); Tue, 19 Oct 2004 18:40:01 -0400 Date: Wed, 20 Oct 2004 00:39:57 +0200 From: Andi Kleen To: Werner Almesberger Cc: linux-kernel , Andrew Morton , ak@suse.de, Jaakko Hyv?tti Subject: Re: [PATCH] no TIOCSBRK/TIOCCBRK in ia32 emulation on amd64 Message-ID: <20041019223957.GA22343@wotan.suse.de> References: <20041019190705.J18873@almesberger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041019190705.J18873@almesberger.net> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 840 Lines: 21 On Tue, Oct 19, 2004 at 07:07:05PM -0300, Werner Almesberger wrote: > In ia32 emulation, the amd64 kernel refuses the ioctls TIOCSBRK > and TIOCCBRK with EINVAL. I've attached a patch that adds them to > the compatibility list. > > Since all architectures have these ioctls ("m68knommu" inherits > them from "m68k", "um" from its host) and use the same code, I > think adding them to compat_ioctl.h is the correct choice (as > opposed to adding them to arch/x86_64/ia32/ia32_ioctl.c). > > The patch is for 2.6.9. I've observed the problem the first time > in 2.6.7. Thanks, looks good. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/