Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S270359AbUJTNXK (ORCPT ); Wed, 20 Oct 2004 09:23:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S270357AbUJTNQz (ORCPT ); Wed, 20 Oct 2004 09:16:55 -0400 Received: from phoenix.infradead.org ([81.187.226.98]:9481 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S270009AbUJTNKS (ORCPT ); Wed, 20 Oct 2004 09:10:18 -0400 Date: Wed, 20 Oct 2004 14:10:15 +0100 From: Christoph Hellwig To: Amit Gud Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org Subject: Re: [PATCH] Remove union u from linux/fs.h Message-ID: <20041020131015.GB20287@infradead.org> Mail-Followup-To: Christoph Hellwig , Amit Gud , linux-kernel@vger.kernel.org, torvalds@osdl.org References: <2c59f00304102002135ca68dd0@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2c59f00304102002135ca68dd0@mail.gmail.com> User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by phoenix.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 728 Lines: 17 On Wed, Oct 20, 2004 at 02:43:59PM +0530, Amit Gud wrote: > Do we need the foolish-looking union with just single entry (void > *generic_ip) in the struct inode linux/fs.h anymore? Why not remove > it? > > This patch does that along with the changes in other parts of the > kernel that references the union. Its compile-tested and applies > cleanly to 2.6.9 vanilla. I don't think we shoould do such purely cosmetic changes that break backwards compatibility during stable series. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/