Subject: Re: Fwd: [Bug 3592] New: pppd "IPCP: timeout sending
	Config-Requests"
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Paul Fulghum <paulkf@microgate.com>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       "Martin J. Bligh" <mbligh@aracnet.com>,
       Linus Torvalds <torvalds@osdl.org>, Alan Cox <alan@redhat.com>
In-Reply-To: <1098199942.2857.7.camel@deimos.microgate.com>
References: <20041019131240.A20243@flint.arm.linux.org.uk>
	 <1098195468.8467.7.camel@deimos.microgate.com>
	 <1098199942.2857.7.camel@deimos.microgate.com>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1098309449.12411.57.camel@localhost.localdomain>
Mime-Version: 1.0
Date: Wed, 20 Oct 2004 22:57:31 +0100
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1067
Lines: 24

On Maw, 2004-10-19 at 16:32, Paul Fulghum wrote:
> PPP line disciplines rely on the previous behavior
> of calling ldisc->close on hangup as a method for
> indicating hangup to the line discipline.
> This is explicitly called out in the PPP ldisc comments.

I had no choice about that really with the current locking. It's on the
list to do further work although I'd not realised some odder pppd
configurations relied upon it until the bug report.

Once I've put out -ac1 to fix the other bugs I consider urgent (not tty)
I'll see what I can do. Really it would nice if the ppp maintainer would
look at this and also fix all the horrible things the code does wrongly
if for example the first byte of a received buffer is an error marker -
in general serial error processing is not robust in the ppp code it
appears.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/