Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S270563AbUJTXPR (ORCPT ); Wed, 20 Oct 2004 19:15:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S270561AbUJTXKn (ORCPT ); Wed, 20 Oct 2004 19:10:43 -0400 Received: from cantor.suse.de ([195.135.220.2]:49049 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S269066AbUJTXAS (ORCPT ); Wed, 20 Oct 2004 19:00:18 -0400 Date: Thu, 21 Oct 2004 00:56:25 +0200 From: Andi Kleen To: "David S. Miller" Cc: David Howells , torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org, discuss@x86-64.org, sparclinux@vger.kernel.org, linuxppc64-dev@ozlabs.org, linux-m68k@vger.kernel.org, linux-sh@m17n.org, linux-arm-kernel@lists.arm.linux.org.uk, parisc-linux@parisc-linux.org, linux-ia64@vger.kernel.org, linux-390@vm.marist.edu, linux-mips@linux-mips.org Subject: Re: [discuss] Re: [PATCH] Add key management syscalls to non-i386 archs Message-ID: <20041020225625.GD995@wotan.suse.de> References: <3506.1098283455@redhat.com> <20041020150149.7be06d6d.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041020150149.7be06d6d.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1091 Lines: 32 On Wed, Oct 20, 2004 at 03:01:49PM -0700, David S. Miller wrote: > > David, I applaud your effort to take care of this. > However, this patch will conflict with what I've > sent into Linus already for Sparc. I also had to > add the sys_altroot syscall entry as well. > > I've mentioned several times that perhaps the best > way to deal with this problem is to purposefully > break the build of platforms when new system calls > are added. > > Simply adding a: > > #error new syscall entries for X and Y needed > > to include/asm-*/unistd.h would handle this just > fine I think. I don't think that's a good idea. Normally new system calls are relatively obscure and the system works fine without them, so urgent action is not needed. And I think we can trust architecture maintainers to regularly sync the system calls with i386. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/