Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S270599AbUJUCfA (ORCPT ); Wed, 20 Oct 2004 22:35:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S270661AbUJUCaN (ORCPT ); Wed, 20 Oct 2004 22:30:13 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:21943 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S270465AbUJUCYq (ORCPT ); Wed, 20 Oct 2004 22:24:46 -0400 Date: Thu, 21 Oct 2004 03:24:42 +0100 From: viro@parcelfarce.linux.theplanet.co.uk To: Jeff Garzik Cc: Linus Torvalds , John Cherry , Matthew Dharm , Kernel Mailing List , "linux-ide@vger.kernel.org" Subject: Re: Linux v2.6.9... (compile stats) Message-ID: <20041021022442.GI23987@parcelfarce.linux.theplanet.co.uk> References: <1098196575.4320.0.camel@cherrybomb.pdx.osdl.net> <20041019161834.GA23821@one-eyed-alien.net> <1098310286.3381.5.camel@cherrybomb.pdx.osdl.net> <20041020224106.GM23987@parcelfarce.linux.theplanet.co.uk> <41770307.5060304@pobox.com> <20041021015522.GH23987@parcelfarce.linux.theplanet.co.uk> <41771813.8090204@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41771813.8090204@pobox.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1088 Lines: 26 On Wed, Oct 20, 2004 at 09:59:47PM -0400, Jeff Garzik wrote: > >Hmm... It misses a bunch of easy stuff, actually (tons of casts to void * > >from what used to be unsigned long and is void __iomem * with your patch). > > feel free to send a delta :) Will do. > >I don't see where you handle PIO stuff, though - no ioport_map() _or_ > >pci_iomap() in sight. > > Correct, that part doesn't exist yet. grep in the above quoted text for > "* map/unap" for the to-do list. > > The mapping of the PIO PCI BARs requires independently mapping at least > 5 (but varies from controller to controller) IO port ranges, and > tracking those mappings in a coherent manner. IDGI. Why do you insist on releasing these guys in library code? Even with iomem case you are creating mappings in driver code, so the reverse should also be done there... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/