Date: Wed, 20 Oct 2004 21:58:40 -0700
From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: vda@port.imtp.ilyichevsk.odessa.ua, rlrevell@joe-job.com, akpm@osdl.org,
       linux-kernel@vger.kernel.org, linux-kernel@gondor.apana.org.au,
       maxk@qualcomm.com, irda-users@lists.sourceforge.net, netdev@oss.sgi.com,
       alain@parkautomat.net
Subject: Re: [PATCH] Make netif_rx_ni preempt-safe
Message-Id: <20041020215840.40f0bacc.davem@davemloft.net>
In-Reply-To: <20041021003503.GA10391@gondor.apana.org.au>
References: <1098230132.23628.28.camel@krustophenia.net>
	<200410202256.56636.vda@port.imtp.ilyichevsk.odessa.ua>
	<1098303951.2268.8.camel@krustophenia.net>
	<200410202332.33583.vda@port.imtp.ilyichevsk.odessa.ua>
	<20041020171508.0e947d08.davem@davemloft.net>
	<20041021003503.GA10391@gondor.apana.org.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 795
Lines: 24

On Thu, 21 Oct 2004 10:35:03 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:

> On Wed, Oct 20, 2004 at 05:15:08PM -0700, David S. Miller wrote:
> >  
> > +int netif_rx_ni(struct sk_buff *skb)
> > +{
> > +       int err = netif_rx(skb);
> > +
> > +       preempt_disable();
> > +       if (softirq_pending(smp_processor_id()))
> > +               do_softirq();
> 
> You need to move the netif_rx call inside the disable as otherwise
> you might be checking the pending flag on the wrong CPU.

Good catch, I've made that fix in my tree.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/