To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Andrew Vasquez <andrew.vasquez@qlogic.com>, Adrian Bunk <bunk@stusta.de>,
       Andrew Morton <akpm@osdl.org>,
       Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.9-rc3-mm3: `risc_code_addr01' multiple definition
References: <20041007015139.6f5b833b.akpm@osdl.org>
	<20041007165849.GA4493@stusta.de> <1097170149.12535.27.camel@praka>
	<1097171420.1718.332.camel@mulgrave>
From: Jes Sorensen <jes@wildopensource.com>
Date: 21 Oct 2004 09:02:07 -0400
In-Reply-To: <1097171420.1718.332.camel@mulgrave>
Message-ID: <yq08ya0rzqo.fsf@jaguar.mkp.net>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 992
Lines: 21

>>>>> "James" == James Bottomley <James.Bottomley@SteelEye.com> writes:

James> On Thu, 2004-10-07 at 12:29, Andrew Vasquez wrote:
>> Hmm, seems the additional 1040 support in qla1280.c is causing name
>> clashes with the firmware image in qlogicfc_asm.c.  Try out the
>> attached patch (not tested) which provides the 1040 firmware image
>> unique variable names.
>> 
>> Looks like there would be some name clashes in qlogicfc and
>> qlogicisp.

James> Is there any reason for these firmware image pointers not to be
James> static?  At least for these drivers which are single files.

I was just thinking the same thing - 2 weeks after everybody else ;-)

You won't see me complaining about a patch doing this for the qla1280
driver.

Cheers,
Jes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/