Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S270835AbUJUVG3 (ORCPT ); Thu, 21 Oct 2004 17:06:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S270946AbUJUUcK (ORCPT ); Thu, 21 Oct 2004 16:32:10 -0400 Received: from fed1rmmtao10.cox.net ([68.230.241.29]:35501 "EHLO fed1rmmtao10.cox.net") by vger.kernel.org with ESMTP id S270825AbUJUU3P (ORCPT ); Thu, 21 Oct 2004 16:29:15 -0400 Date: Thu, 21 Oct 2004 13:29:13 -0700 From: Tom Rini To: Kernel Mailing List , Linus Torvalds , Andrew Morton Cc: bk-commits-head@vger.kernel.org Subject: Re: [PATCH] ppc: fix build with O=$(output_dir) Message-ID: <20041021202913.GA335@smtp.west.cox.net> References: <200410211910.i9LJAKjf029014@hera.kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410211910.i9LJAKjf029014@hera.kernel.org> User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1606 Lines: 36 On Thu, Oct 21, 2004 at 05:56:14PM +0000, roland@topspin.com wrote: > ChangeSet 1.2040, 2004/10/21 10:56:14-07:00, roland@topspin.com > > [PATCH] ppc: fix build with O=$(output_dir) > > Recent changes to arch/ppc/boot/lib/Makefile cause > > CC arch/ppc/boot/lib/../../../../lib/zlib_inflate/infblock.o > Assembler messages: > FATAL: can't create arch/ppc/boot/lib/../../../../lib/zlib_inflate/infblock.o: No such file or directory > > when building a ppc kernel using O=$(output_dir) with CONFIG_ZLIB_INFLATE=n, > because the $(output_dir)/lib/zlib_inflate directory doesn't get created. > > This patch, which makes arch/ppc/boot/lib/Makefile create the > directory if needed, is one fix for the problem. > > Signed-off-by: Roland Dreier > Signed-off-by: Andrew Morton > Signed-off-by: Linus Torvalds Can we back this out please? As I noted on lkml once I saw this, it still doesn't fix the problem of overwriting files in lib/zlib_inflate/ if ZLIB_INFLATE!=n, and adding explicit rules for lib/zlib_inflate/foo.c -> ./foo.o looks quite bad (it's 2 calls if we want checker to get invoked, one if we skip doing that). At the end of the thread, both Roland and I were hoping Sam knew of a clever solution to this. -- Tom Rini http://gate.crashing.org/~trini/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/